Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_topic API #288

Merged
merged 32 commits into from
Nov 1, 2023
Merged

read_topic API #288

merged 32 commits into from
Nov 1, 2023

Conversation

neekolas
Copy link
Contributor

Summary

The only query patterns I can see in our use-cases are to read a topic to completion, after a given timestamp. So, I made a method in the ApiWrapper that does that and handles pagination for the caller.

richardhuaaa and others added 28 commits October 25, 2023 15:25
@richardhuaaa
Add key_store table and generate
db813ba
@richardhuaaa
Implement store/fetch/delete traits
f9c6ec8
@richardhuaaa
Add SQL key store
257d5b6
@richardhuaaa
Use SQL key store for provider, remove in-memory key store
6af1384
@richardhuaaa
Use reference to encrypted store to allow multiple consumers
a404c20
@richardhuaaa
Tidy identity
acd42b8
@richardhuaaa
Add identity table, queries, and unit tests
0a53a11
@richardhuaaa
Persist and retrieve identity from storage inside builder
4fb1059
@richardhuaaa
Tidy up names and types
598b5ea
@neekolas
Merge branch 'main' into rich/sqlite-store
c8780f0
@neekolas
Update Diesel
9dad361
@neekolas
Hard code ciphersuite
b1f411b
@richardhuaaa
Add tests and fix bugs
091afdb
@richardhuaaa
Fix lints
18c6aa4
@richardhuaaa @insipx
Update xmtp_mls/src/storage/encrypted_store/mod.rs
dae1c74 
Co-authored-by: Andrew Plaza <[email protected]>
@richardhuaaa
Dont use the word Error in error names
77aa94b
@richardhuaaa
Move identity initialization to identity strategy
5278d13
@richardhuaaa
Merge remote-tracking branch 'origin/main' into rich/sqlite-store
a6c5095
@neekolas
Add create key packages methods
04f5dd9
@neekolas
Merge branch 'main' into create-key-packages
7a27e56
@neekolas
Merge branch 'rich/sqlite-store' of github.com:xmtp/libxmtp into rich…
7000fb4 
…/sqlite-store
@neekolas
Merge branch 'rich/sqlite-store' into create-key-packages
2b4b0be
@neekolas
Add verified key package handling
34d42f0
@neekolas
Add comment
249daba
@neekolas
Add read_topic API
49f8332
@neekolas
Remove unused lifetime
23fc060
@neekolas
Merge branch 'create-key-packages' into nmolnar/read-topic-api
c632b9f
@neekolas
Add times check
77f1829
@neekolas neekolas changed the title Read Topic API read_topic API Oct 30, 2023
Base automatically changed from rich/sqlite-store to main October 30, 2023 15:32
@neekolas neekolas marked this pull request as ready for review October 30, 2023 16:14
@neekolas neekolas requested a review from a team October 30, 2023 16:14
@richardhuaaa
Copy link
Contributor

Nooby question - is there a max page size our API supports? If our client is always reading to completion, what is the purpose of paging under the hood?

@neekolas
Copy link
Contributor Author

neekolas commented Nov 1, 2023

@richardhuaaa 100 item max page size

richardhuaaa
richardhuaaa approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@richardhuaaa richardhuaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xmtp_mls/src/api_client_wrapper.rs Outdated Show resolved Hide resolved
xmtp_mls/src/api_client_wrapper.rs Outdated Show resolved Hide resolved
@neekolas neekolas merged commit 36c2c64 into main Nov 1, 2023
16 checks passed
@neekolas neekolas deleted the nmolnar/read-topic-api branch November 1, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx left review comments

@richardhuaaa richardhuaaa richardhuaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neekolas @richardhuaaa @insipx